<html>
<head><meta charset="utf-8"><title>crater triage 1.50 · t-release · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/index.html">t-release</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E50.html">crater triage 1.50</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="222003271"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.50/near/222003271" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E50.html#222003271">(Jan 07 2021 at 21:26)</a>:</h4>
<p>We'll need to triage the 1.50 crater run soon, and I'm interested in finding out if <span class="user-mention" data-user-id="224872">@rylev</span> you might be interested in leading that effort (maybe in concert with a few others).</p>
<p>The issue with results is here - <a href="https://github.com/rust-lang/rust/issues/80667">https://github.com/rust-lang/rust/issues/80667</a> - they should be ready in around an hour. I would like to see this done by next Wednesday, roughly.</p>



<a name="222003553"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.50/near/222003553" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E50.html#222003553">(Jan 07 2021 at 21:29)</a>:</h4>
<p>I’m happy to lead the effort. Is all that needs to be done is classifying errors and opening issues for regressions?</p>



<a name="222003692"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.50/near/222003692" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E50.html#222003692">(Jan 07 2021 at 21:30)</a>:</h4>
<p>yep, same as last time.</p>



<a name="222274926"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.50/near/222274926" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E50.html#222274926">(Jan 11 2021 at 09:26)</a>:</h4>
<p>FYI: Going to start this now</p>



<a name="222278840"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.50/near/222278840" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E50.html#222278840">(Jan 11 2021 at 10:14)</a>:</h4>
<p>I've gone through all of the compile time error for <code>regressed: root</code>.</p>
<ul>
<li><code>E0034</code>, <code>E0061</code>, and <code>E0277</code> are all cases of new APIs being stablized (<code>Ord::clamp</code> and <code>bool::then</code>) which were defined on extension traits.</li>
<li><code>E0597</code> seems to be <a href="https://crater-reports.s3.amazonaws.com/beta-1.50-1/beta-2021-01-01/reg/euca-0.1.0/log.txt">the only interesting failure</a>. The borrower checker finds an issue on beta but not on stable. It seems like this code should _not_ compile (making beta correct) as moving the <code>&amp;mut</code> borrow out of argument position to its own variable (which should extend the lifetime if anything) causes a borrow checker failure even on stable. I can't find an issue that references this though.</li>
</ul>



<a name="222279678"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.50/near/222279678" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E50.html#222279678">(Jan 11 2021 at 10:23)</a>:</h4>
<ul>
<li>Next is a <a href="https://crater-reports.s3.amazonaws.com/beta-1.50-1/beta-2021-01-01/gh/devrandom.utxo-oracle/log.txt">linker error</a> with duplicate symbols. I don't see any obvious reason for this failure at this point.</li>
</ul>



<a name="222280108"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.50/near/222280108" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E50.html#222280108">(Jan 11 2021 at 10:28)</a>:</h4>
<ul>
<li>The last build <a href="https://crater-reports.s3.amazonaws.com/beta-1.50-1/beta-2021-01-01/reg/allegro_examples-0.0.41/log.txt">failed</a> is from an <a href="https://github.com/SiegeLord/RustAllegro/blob/master/examples/build.rs#L10"><code>env var not being set</code></a>, but I don't know how the tests passed in the first place...</li>
</ul>



<a name="222280327"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.50/near/222280327" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E50.html#222280327">(Jan 11 2021 at 10:30)</a>:</h4>
<ul>
<li>The rest are test failed. <span class="user-mention" data-user-id="116122">@simulacrum</span> is the procedure to quickly scan and see if any seem like they might not be due to the tests not being 100% reproducible (i.e., having some randomness in them).?</li>
</ul>



<a name="222286638"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.50/near/222286638" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E50.html#222286638">(Jan 11 2021 at 11:40)</a>:</h4>
<p><span class="user-mention" data-user-id="224872">@rylev</span> there isn't unfortunately, it's pretty much up to guess work. I usually don't try to rerun them though, and just look at the failure- if it looks plausibly deterministic I will file an issue.</p>
<p>One of the goals I've long had for crater is to automate rerunning regressed crates, say, 3 times to try and get rid of ones that fail spuriously.</p>



<a name="222310171"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.50/near/222310171" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eric Huss <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E50.html#222310171">(Jan 11 2021 at 15:20)</a>:</h4>
<p>The env var not set error is a cargo regression: <a href="https://github.com/rust-lang/cargo/issues/9063">https://github.com/rust-lang/cargo/issues/9063</a></p>



<a name="222462306"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.50/near/222462306" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E50.html#222462306">(Jan 12 2021 at 17:04)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> for the new APIs being stabalized causing code to break. Does this need to be reported anywhere?</p>



<a name="222462480"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.50/near/222462480" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E50.html#222462480">(Jan 12 2021 at 17:05)</a>:</h4>
<p>Please file an issue - I'd like to try to start/continue to note such things, even though it's super likely we'll close as won't fix pretty quickly</p>



<a name="222465726"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.50/near/222465726" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E50.html#222465726">(Jan 12 2021 at 17:27)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> an update: I've filed issues or left comments for all the issues I listed above with the exception of the <a href="https://crater-reports.s3.amazonaws.com/beta-1.50-1/beta-2021-01-01/gh/devrandom.utxo-oracle/log.txt">linker error</a> which i'm not quite sure how to report. </p>
<p>I still need to go through the test failures, but I won't have time to do that until tomorrow.</p>



<a name="222466094"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.50/near/222466094" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E50.html#222466094">(Jan 12 2021 at 17:30)</a>:</h4>
<p>Let's file an issue on the linker error, maybe someone can get a bisect or mcve going</p>



<a name="222466212"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.50/near/222466212" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E50.html#222466212">(Jan 12 2021 at 17:30)</a>:</h4>
<p>If you can leave a comment on the crater issue today/tomorrow listing the issues files (just numbers or numbers and titles) that would be amazing</p>



<a name="222466768"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.50/near/222466768" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E50.html#222466768">(Jan 12 2021 at 17:34)</a>:</h4>
<ul>
<li><a href="https://github.com/rust-lang/cargo/issues/9063#issuecomment-758814836">Cargo: DEP_* env variable not set in nightly test run</a></li>
<li><a href="https://github.com/rust-lang/rust/issues/80950">Code breaks due to newly stabalized std lib methods <code>Ord::clamp</code> and <code>bool::then</code></a></li>
<li><a href="https://github.com/rust-lang/rust/issues/80949">Borrow checker reports function param as not living long enough</a></li>
<li><a href="https://github.com/rust-lang/rust/issues/80951">Duplicate symbol linker error</a></li>
</ul>



<a name="222617552"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.50/near/222617552" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E50.html#222617552">(Jan 13 2021 at 17:37)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> seeing a bunch of tests failing due to an issue that I believe is related to or is exactly (<a href="https://github.com/rust-lang/rust/issues/77713">https://github.com/rust-lang/rust/issues/77713</a>). In test <code>#[forbid(warnings)]</code> is set and this conflicts with various <code>#[deny(..)]</code> annotations</p>



<a name="222617595"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.50/near/222617595" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E50.html#222617595">(Jan 13 2021 at 17:37)</a>:</h4>
<p>Some of the error messages are a bit unexpected too:</p>
<div class="codehilite"><pre><span></span><code>error[E0453]: allow(unused_qualifications) incompatible with previous forbid
   --&gt; src/lib.rs:105:38
    |
25  |     warnings
    |     -------- `forbid` level set here
...
105 | #[derive(Debug, PartialEq, Eq, Hash, Clone)]
    |                                      ^^^^^ overruled by previous forbid
</code></pre></div>



<a name="222618010"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.50/near/222618010" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E50.html#222618010">(Jan 13 2021 at 17:40)</a>:</h4>
<p>This was an issue for 1.49 and was reverted out</p>



<a name="222618296"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.50/near/222618296" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E50.html#222618296">(Jan 13 2021 at 17:42)</a>:</h4>
<p>huh</p>



<a name="222618309"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.50/near/222618309" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E50.html#222618309">(Jan 13 2021 at 17:42)</a>:</h4>
<p>file an issue please</p>



<a name="222618368"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.50/near/222618368" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E50.html#222618368">(Jan 13 2021 at 17:43)</a>:</h4>
<p>I am.. surprised, I guess, by people setting forbid, but would like to dig in more</p>



<a name="222619895"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.50/near/222619895" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E50.html#222619895">(Jan 13 2021 at 17:55)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> I went through ~50% of the test failures and the above was the only issue I found. There might be more issues but I don't have time to finish going through all the crates today unfortunately. Do you think this is enough for this first crater run? I can continue tomorrow.</p>



<a name="222620450"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.50/near/222620450" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E50.html#222620450">(Jan 13 2021 at 17:59)</a>:</h4>
<p>yes, this is great - I think we've likely discovered most things. Not sure what you mean by "first" crater run - we usually only do one. Triaging the rustdoc one is pretty quick since it mirrors the rustc one for a good portion of problems usually</p>



<a name="222620632"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.50/near/222620632" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E50.html#222620632">(Jan 13 2021 at 18:00)</a>:</h4>
<p>when you get a chance if you can record all of the issues you filed on <a href="https://github.com/rust-lang/rust/issues/80667">https://github.com/rust-lang/rust/issues/80667</a> as a comment that would help me keep track of things</p>



<a name="222693805"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.50/near/222693805" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E50.html#222693805">(Jan 14 2021 at 09:15)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/241545-t-release/topic/crater.20triage.201.2E50/near/222620450">said</a>:</p>
<blockquote>
<p>Not sure what you mean by "first" crater run - we usually only do one. Triaging the rustdoc one is pretty quick since it mirrors the rustc one for a good portion of problems usually</p>
</blockquote>
<p>Ah sorry, I was under the impression we do 2.</p>



<a name="222694221"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.50/near/222694221" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E50.html#222694221">(Jan 14 2021 at 09:20)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/241545-t-release/topic/crater.20triage.201.2E50/near/222620632">said</a>:</p>
<blockquote>
<p>when you get a chance if you can record all of the issues you filed on <a href="https://github.com/rust-lang/rust/issues/80667">https://github.com/rust-lang/rust/issues/80667</a> as a comment that would help me keep track of things</p>
</blockquote>
<p>Done: <a href="https://github.com/rust-lang/rust/issues/80667#issuecomment-760068319">https://github.com/rust-lang/rust/issues/80667#issuecomment-760068319</a></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>